From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8E88D4765E0 for ; Wed, 23 Dec 2020 21:21:22 +0300 (MSK) Date: Wed, 23 Dec 2020 21:20:37 +0300 From: Sergey Kaplun Message-ID: <20201223182037.GE9101@root> References: <20201220212715.GO5396@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201220212715.GO5396@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH luajit v1 01/11] build: add src dir in building List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Igor, Thanks for the review! On 21.12.20, Igor Munkin wrote: > Sergey, > > Thanks for the patch, but I guess we need to restructure the sources in > a separate series if we want to (but I personally strongly doubt). > > I don't want to mix the new layout you want to introduce with the > feature. E.g. we already introduced , however, I also prefer > the uJIT layout (i.e. lib/misc.c). LuaJIT already provides a profiler > that is implemented in scope of lj_profile.[hc]. Let's leave everything > "flat" in directory to save the sources consistency. Please, drop > this patch out of the series. OK, I'll drop this commit. Side note: At least we should change the layout of all sources (if we want) after we'll sync up with upstream. It makes this procedure less painful. As for me new layout _after_ sync up will not disturb applying single patches. > > -- > Best regards, > IM -- Best regards, Sergey Kaplun