From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DBA1C4765E0 for ; Wed, 23 Dec 2020 16:05:05 +0300 (MSK) Date: Wed, 23 Dec 2020 13:05:04 +0000 From: Kirill Yukhin Message-ID: <20201223130504.szb3x6sdj5p6mijy@tarantool.org> References: <20201222130858.16812-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201222130858.16812-1-skaplun@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] lua: avoid panic if HOOK_GC is not active List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Kaplun Cc: Michael Filonenko , tarantool-patches@dev.tarantool.org Hello, On 22 Dec 16:08, Sergey Kaplun via Tarantool-patches wrote: > Panic at fiber.yield() occures inside any active hook. > > This is the regression from 96dbc49d097a96af5273cce2b5663db5917f4ea9 > ('lua: prohibit fiber yield when GC hook is active'). > > This patch fixes false positive panic in cases when VM is not running > a GC hook. > > Reported-by: Michael Filonenko > Follows up #4727 > Closes #5649 I've checked your patch into 1.10, 2.5, 2.6 and master. -- Regards, Kirill Yukhin