From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C640E4765E0
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 23 Dec 2020 09:12:41 +0300 (MSK)
Date: Wed, 23 Dec 2020 09:12:39 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20201223061239.GA72819@hpalx>
References: <624bfee981237f22842b083fb3e0093b9c06e780.1591536783.git.avtikhon@tarantool.org>
 <20200607140346.kjcgjk3ufcmn4vmd@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200607140346.kjcgjk3ufcmn4vmd@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add packaging for
	Fedora 32
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Alexander, thanks for the review. Please check my comments below.

On Sun, Jun 07, 2020 at 05:03:46PM +0300, Alexander Turenko wrote:
> On Sun, Jun 07, 2020 at 04:40:40PM +0300, Alexander V. Tikhonov wrote:
> > Added packaging jobs for Fedora 32.
> > 
> > Closes #4966
> > 
> > (cherry picked from commit 5613beedf83a679b725cea816a4176eabe3e1601)
> 
> Are you added 'cherry picked from' by mistake?
> 

Right the wrong branch was used, in real branch to be used is:
  avtikhon/gh-4966-fedora-32-full-ci

> > Also added job to travis-ci.
> > ---
> > 
> > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4966-fedora-32-old-full-ci
> > Issue: https://github.com/tarantool/tarantool/issues/4966
> > 
> > The patch should be committed only after commit
> >   bdd90686f82ec2e22d4ea7adfb9a6173bcc8af4a
> > will be pushed to be able to fix Fedoar 32 build.
> 
> It should not be pushed until all warnings from [1] will be resolved or
> at least will be proven to be false-positive.
> 
> [1]: https://github.com/tarantool/tarantool/issues/4966
>

Right, issue #4966 is fixed and closed for now.

> > 
> > Also current fix is on for 1.10 branch only, for other branches
> > need to make changes in .travis.yml changes:
> > 2.4: 1.10 -> 2.4
> > 2.3: 1.10 -> 2.3
> > 2.2: 1.10 -> 2.2
> > For master branch .travis.yml doesn't need to be updated.
> > Use 5613beedf83a679b725cea816a4176eabe3e1601 for master branch.
> 
> I would rather implement the patch on top of master and mention what
> should be done after cherry-picking for 2.4, 2.3 and 1.10.

Not needed for now, due to travis-ci is not used any more.