From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1A66C4765E0
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 21 Dec 2020 13:43:47 +0300 (MSK)
Date: Mon, 21 Dec 2020 13:43:42 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201221104342.GV5396@tarantool.org>
References: <cover.1608142899.git.skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1608142899.git.skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH luajit v1 00/11] LuaJIT memory
	profiler
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sergey,

Thanks for the series! I reviewed the patches (1..4, 7, 10) and expect
considerable changes in both code and sources layout, so I guess we can
proceed in the v2. Anyway, the patches 5 and 6 looks independent to
these changes and I review them in a while. The patches 8, 9 and 11 may
change in the next version, so I'll glance them but the full review will
be made for the next version.

On 16.12.20, Sergey Kaplun wrote:
> This patch provides a Lua interface for memory profiler in LuaJIT
> and the corresponding parser of profiled data.
> 
> Issues: https://github.com/tarantool/tarantool/issues/5442
>         https://github.com/tarantool/tarantool/issues/5490
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5442-luajit-memory-profiler
> 
> CI:     https://gitlab.com/tarantool/tarantool/-/pipelines/230917973
> 
> RFC: https://lists.tarantool.org/pipermail/tarantool-discussions/2020-December/000144.html
> 
> @ChangeLog:
>  - Introduce LuaJIT memory profiler (gh-5442).

IIRC, there is a separate issue for memprof parse, so it's worth to add
it to the ChangeLog also.

> 
> Sergey Kaplun (11):
>   build: add src dir in building
>   utils: introduce leb128 reader and writer
>   profile: introduce profiler writing module
>   profile: introduce symtab write module
>   vm: introduce LFUNC and FFUNC vmstates
>   core: introduce new mem_L field
>   debug: move debug_frameline to public module API
>   profile: introduce memory profiler
>   misc: add Lua API for memory profiler
>   tools: introduce tools directory
>   profile: introduce profile parser
> 

<snipped>

> 
> -- 
> 2.28.0
> 

-- 
Best regards,
IM