From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B2BC14304B4 for ; Thu, 17 Dec 2020 15:41:52 +0300 (MSK) Date: Thu, 17 Dec 2020 15:41:59 +0300 From: Alexander Turenko Message-ID: <20201217124159.jaozjg2425vqkjv3@tkn_work_nb> References: <20201215142527.560937-1-void@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2] base64: Properly ignore invalid characters List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Vasiliev Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy On Thu, Dec 17, 2020 at 12:41:48PM +0300, Leonid Vasiliev via Tarantool-patches wrote: > Hi! Thank you for the patch. > Generally LGTM. > See some comments below: > > According to https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message > "Description is what the patch does, started from lowercase letter, > without a dot in the end, in the imperative mood." > ("properly..."). > I could be wrong, but it seems like is not written in an > imperative mood. A commit subject should be in the imperative mood. But there is more freedom for a commit message body.