From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id ACEC845C304
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 11 Dec 2020 15:04:59 +0300 (MSK)
Date: Fri, 11 Dec 2020 12:04:58 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20201211120458.GA12730@tarantool.org>
References: <20201113115318.16331-1-i.kosarev@tarantool.org>
 <3ff7ba65-993d-02df-9e54-6e35eb625ac8@tarantool.org>
 <20201210120048.GA1319@tarantool.org>
 <20201210184509.GA21378@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201210184509.GA21378@hpalx>
Subject: Re: [Tarantool-patches] [PATCH v5] core: introduce evenly
 distributed int64 random in range
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 10 Dec 21:45, Alexander V. Tikhonov wrote:
> Hi All, thanks for the patch, as I see no new degradation found in
> gitlab-ci testing commit criteria pipeline [1], patch LGTM.
> 
> [1] - https://gitlab.com/tarantool/tarantool/-/pipelines/227898537

Pushed to master, 2.6 and 2.5. Original branch is dropped.

> On Thu, Dec 10, 2020 at 12:00:48PM +0000, Nikita Pettik wrote:
> > On 13 Nov 23:30, Vladislav Shpilevoy wrote:
> > > LGTM.
> > 
> > LGTM as well. Latest version rebased on master is on branch:
> > https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5075-fine-random-in-range
> > 
> > I see several CI fails (release_lto/ubuntu_19_10) but they seem to be
> > unrelated to introduced changes. Aleksander, is it ok to push this patch
> > to master?
> >