From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com
 [209.85.167.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 80C8445C304
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 11 Dec 2020 13:38:08 +0300 (MSK)
Received: by mail-lf1-f65.google.com with SMTP id y19so12620870lfa.13
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 11 Dec 2020 02:38:08 -0800 (PST)
Date: Fri, 11 Dec 2020 13:38:04 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201211103804.GD544004@grain>
References: <20201210161832.729439-1-gorcunov@gmail.com>
 <20201210161832.729439-4-gorcunov@gmail.com>
 <f73f257f-b87f-bc88-d2e8-3028d13866ae@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f73f257f-b87f-bc88-d2e8-3028d13866ae@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 3/4] crash: move fatal signal
	handling in
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>, tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Fri, Dec 11, 2020 at 12:31:18PM +0300, Serge Petrenko wrote:
> > --- /dev/null
> > +++ b/src/lib/core/crash.c
> > @@ -0,0 +1,291 @@
> > +/*
> > + * SPDX-License-Identifier: BSD-2-Clause
> > + *
> > + * Copyright 2010-2020, Tarantool AUTHORS, please see AUTHORS file.
> 
> 
> I haven't seen us using such a license before.
> It must be fine, I'm just not familiar with this.

We've been discussing this spdx reference in chat and I've got no
rejection so far. So I think using short ref a way more convenient
instead of pushing the big header to each file.

https://spdx.org/licenses/
https://en.wikipedia.org/wiki/Software_Package_Data_Exchange

> > +static void
> > +crash_report_stderr(struct crash_info *cinfo)
> > +{
> > +	if (cinfo->signo == SIGSEGV) {
> > +		fprintf(stderr, "Segmentation fault\n");
> > +		const char *signal_code_repr = 0;
> 
> 
> Please use NULL for pointers.

Both comments are fixed and force pushed. Thanks!