From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A7DFE45C305 for ; Tue, 8 Dec 2020 21:04:22 +0300 (MSK) Date: Tue, 8 Dec 2020 21:04:26 +0300 From: Alexander Turenko Message-ID: <20201208180426.ul5c2sms35ur4tyl@tkn_work_nb> References: <4e30fd34-ece6-eb7b-720f-e019b2511fb2@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4e30fd34-ece6-eb7b-720f-e019b2511fb2@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1] Support to run tests with Python 3 List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org If you want my opinion, I think that the technical changes for support Python 3 are enough. I don't mind style fixes, though. > > > -        print len(tuple[0]) == size and 'ok' or 'fail', > > > -        print > > > -    print > > > +        print(len(tuple[0]) == size and 'ok' or 'fail', end="") > > > +        print() > > > +    print() > > > > 6) What for this `print()` needed? (and in the same changes below). > > I don't know why you asked me because I'm not an author of these changes. > > But I'll try to answer. <...> I see, you answered the question, but I would highlight this part of the discussion. When you touch some code, you becomes its owner. Any questions like 'how it supposed to work / how it works' are applicable. If a developer would legally respond 'it is not my deal' on questions regarding changed code, we would accumulate tech debts even faster than now. Of course, there is a line, where it starts to contradict with a common sense, but in general a knowledge about the changed code is required to actually change it. I find this approach nice. It pushes me to know more and be more confident about my patches.