From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6121745C305 for ; Tue, 8 Dec 2020 11:48:26 +0300 (MSK) Received: by mail-lj1-f178.google.com with SMTP id m13so2062498ljo.11 for ; Tue, 08 Dec 2020 00:48:26 -0800 (PST) Date: Tue, 8 Dec 2020 11:48:23 +0300 From: Cyrill Gorcunov Message-ID: <20201208084823.GH2303@grain> References: <20201203140446.66312-1-gorcunov@gmail.com> <20201203140446.66312-4-gorcunov@gmail.com> <4877abd0-72b4-57c0-a257-cf991ed8721a@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4877abd0-72b4-57c0-a257-cf991ed8721a@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v3 3/3] test: add replication/gh-5446-sqync-eval-quorum.test.lua List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: Mons Anderson , tml On Sat, Dec 05, 2020 at 12:52:25AM +0100, Vladislav Shpilevoy wrote: > Thanks for the patch! > > See 5 comments below. > Here is a force-pushed update - I keep use explicit "start server replica1" which allows me to grep update of quorum one by one - I dropped unused space creation - Raised number of repicas up to 6 - Since the patch is big i prefer to have it as a separate commit It is unclear for me yet how to detect the replication failure when we would stop replica. Could you please help? --- From: Cyrill Gorcunov Date: Tue, 24 Nov 2020 17:11:23 +0300 Subject: [PATCH 3/3] test: add replication/gh-5446-qsync-eval-quorum.test.lua Part-of #5446 Signed-off-by: Cyrill Gorcunov --- .../gh-5446-qsync-eval-quorum.result | 193 ++++++++++++++++++ .../gh-5446-qsync-eval-quorum.test.lua | 76 +++++++ test/replication/replica-quorum-1.lua | 1 + test/replication/replica-quorum-2.lua | 1 + test/replication/replica-quorum-3.lua | 1 + test/replication/replica-quorum-4.lua | 1 + test/replication/replica-quorum-5.lua | 1 + test/replication/replica-quorum-6.lua | 1 + 8 files changed, 275 insertions(+) create mode 100644 test/replication/gh-5446-qsync-eval-quorum.result create mode 100644 test/replication/gh-5446-qsync-eval-quorum.test.lua create mode 120000 test/replication/replica-quorum-1.lua create mode 120000 test/replication/replica-quorum-2.lua create mode 120000 test/replication/replica-quorum-3.lua create mode 120000 test/replication/replica-quorum-4.lua create mode 120000 test/replication/replica-quorum-5.lua create mode 120000 test/replication/replica-quorum-6.lua diff --git a/test/replication/gh-5446-qsync-eval-quorum.result b/test/replication/gh-5446-qsync-eval-quorum.result new file mode 100644 index 000000000..ebe0aede7 --- /dev/null +++ b/test/replication/gh-5446-qsync-eval-quorum.result @@ -0,0 +1,193 @@ +-- test-run result file version 2 +test_run = require('test_run').new() + | --- + | ... +engine = test_run:get_cfg('engine') + | --- + | ... + +box.schema.user.grant('guest', 'replication') + | --- + | ... + +-- Test syntax error +box.cfg{replication_synchro_quorum = "aaa"} + | --- + | - error: 'Incorrect value for option ''replication_synchro_quorum'': [string "local + | expr = [[aaa]]..."]:7: Expression should return a number' + | ... + +-- Make sure we were configured in a proper way +box.cfg { replication_synchro_quorum = "N/2+1", replication_synchro_timeout = 1000 } + | --- + | ... +match = 'set \'replication_synchro_quorum\' configuration option to \"N\\/2%+1' + | --- + | ... +test_run:grep_log("default", match) ~= nil + | --- + | - true + | ... + +test_run:cmd('create server replica1 with rpl_master=default,\ + script="replication/replica-quorum-1.lua"') + | --- + | - true + | ... +test_run:cmd('start server replica1 with wait=True, wait_load=True') + | --- + | - true + | ... + +-- 1 replica -> replication_synchro_quorum = 1/2 + 1 = 1 +match = 'update replication_synchro_quorum = 1' + | --- + | ... +test_run:grep_log("default", match) ~= nil + | --- + | - true + | ... + +test_run:cmd('create server replica2 with rpl_master=default,\ + script="replication/replica-quorum-2.lua"') + | --- + | - true + | ... +test_run:cmd('start server replica2 with wait=True, wait_load=True') + | --- + | - true + | ... + +-- 2 replicas -> replication_synchro_quorum = 2/2 + 1 = 2 +match = 'update replication_synchro_quorum = 2' + | --- + | ... +test_run:grep_log("default", match) ~= nil + | --- + | - true + | ... + +test_run:cmd('create server replica3 with rpl_master=default,\ + script="replication/replica-quorum-3.lua"') + | --- + | - true + | ... +test_run:cmd('start server replica3 with wait=True, wait_load=True') + | --- + | - true + | ... + +-- 3 replicas -> replication_synchro_quorum = 3/2 + 1 = 2 +match = 'update replication_synchro_quorum = 2' + | --- + | ... +test_run:grep_log("default", match) ~= nil + | --- + | - true + | ... + +test_run:cmd('create server replica4 with rpl_master=default,\ + script="replication/replica-quorum-4.lua"') + | --- + | - true + | ... +test_run:cmd('start server replica4 with wait=True, wait_load=True') + | --- + | - true + | ... + +-- 4 replicas -> replication_synchro_quorum = 4/2 + 1 = 3 +match = 'update replication_synchro_quorum = 3' + | --- + | ... +test_run:grep_log("default", match) ~= nil + | --- + | - true + | ... + +test_run:cmd('create server replica5 with rpl_master=default,\ + script="replication/replica-quorum-5.lua"') + | --- + | - true + | ... +test_run:cmd('start server replica5 with wait=True, wait_load=True') + | --- + | - true + | ... + +test_run:cmd('create server replica6 with rpl_master=default,\ + script="replication/replica-quorum-6.lua"') + | --- + | - true + | ... +test_run:cmd('start server replica6 with wait=True, wait_load=True') + | --- + | - true + | ... + +-- 6 replicas -> replication_synchro_quorum = 6/2 + 1 = 4 +match = 'update replication_synchro_quorum = 4' + | --- + | ... +test_run:grep_log("default", match) ~= nil + | --- + | - true + | ... + +test_run:cmd('stop server replica1') + | --- + | - true + | ... +test_run:cmd('delete server replica1') + | --- + | - true + | ... + +test_run:cmd('stop server replica2') + | --- + | - true + | ... +test_run:cmd('delete server replica2') + | --- + | - true + | ... + +test_run:cmd('stop server replica3') + | --- + | - true + | ... +test_run:cmd('delete server replica3') + | --- + | - true + | ... + +test_run:cmd('stop server replica4') + | --- + | - true + | ... +test_run:cmd('delete server replica4') + | --- + | - true + | ... + +test_run:cmd('stop server replica5') + | --- + | - true + | ... +test_run:cmd('delete server replica5') + | --- + | - true + | ... + +test_run:cmd('stop server replica6') + | --- + | - true + | ... +test_run:cmd('delete server replica6') + | --- + | - true + | ... + +box.schema.user.revoke('guest', 'replication') + | --- + | ... diff --git a/test/replication/gh-5446-qsync-eval-quorum.test.lua b/test/replication/gh-5446-qsync-eval-quorum.test.lua new file mode 100644 index 000000000..71adcad90 --- /dev/null +++ b/test/replication/gh-5446-qsync-eval-quorum.test.lua @@ -0,0 +1,76 @@ +test_run = require('test_run').new() +engine = test_run:get_cfg('engine') + +box.schema.user.grant('guest', 'replication') + +-- Test syntax error +box.cfg{replication_synchro_quorum = "aaa"} + +-- Make sure we were configured in a proper way +box.cfg { replication_synchro_quorum = "N/2+1", replication_synchro_timeout = 1000 } +match = 'set \'replication_synchro_quorum\' configuration option to \"N\\/2%+1' +test_run:grep_log("default", match) ~= nil + +test_run:cmd('create server replica1 with rpl_master=default,\ + script="replication/replica-quorum-1.lua"') +test_run:cmd('start server replica1 with wait=True, wait_load=True') + +-- 1 replica -> replication_synchro_quorum = 1/2 + 1 = 1 +match = 'update replication_synchro_quorum = 1' +test_run:grep_log("default", match) ~= nil + +test_run:cmd('create server replica2 with rpl_master=default,\ + script="replication/replica-quorum-2.lua"') +test_run:cmd('start server replica2 with wait=True, wait_load=True') + +-- 2 replicas -> replication_synchro_quorum = 2/2 + 1 = 2 +match = 'update replication_synchro_quorum = 2' +test_run:grep_log("default", match) ~= nil + +test_run:cmd('create server replica3 with rpl_master=default,\ + script="replication/replica-quorum-3.lua"') +test_run:cmd('start server replica3 with wait=True, wait_load=True') + +-- 3 replicas -> replication_synchro_quorum = 3/2 + 1 = 2 +match = 'update replication_synchro_quorum = 2' +test_run:grep_log("default", match) ~= nil + +test_run:cmd('create server replica4 with rpl_master=default,\ + script="replication/replica-quorum-4.lua"') +test_run:cmd('start server replica4 with wait=True, wait_load=True') + +-- 4 replicas -> replication_synchro_quorum = 4/2 + 1 = 3 +match = 'update replication_synchro_quorum = 3' +test_run:grep_log("default", match) ~= nil + +test_run:cmd('create server replica5 with rpl_master=default,\ + script="replication/replica-quorum-5.lua"') +test_run:cmd('start server replica5 with wait=True, wait_load=True') + +test_run:cmd('create server replica6 with rpl_master=default,\ + script="replication/replica-quorum-6.lua"') +test_run:cmd('start server replica6 with wait=True, wait_load=True') + +-- 6 replicas -> replication_synchro_quorum = 6/2 + 1 = 4 +match = 'update replication_synchro_quorum = 4' +test_run:grep_log("default", match) ~= nil + +test_run:cmd('stop server replica1') +test_run:cmd('delete server replica1') + +test_run:cmd('stop server replica2') +test_run:cmd('delete server replica2') + +test_run:cmd('stop server replica3') +test_run:cmd('delete server replica3') + +test_run:cmd('stop server replica4') +test_run:cmd('delete server replica4') + +test_run:cmd('stop server replica5') +test_run:cmd('delete server replica5') + +test_run:cmd('stop server replica6') +test_run:cmd('delete server replica6') + +box.schema.user.revoke('guest', 'replication') diff --git a/test/replication/replica-quorum-1.lua b/test/replication/replica-quorum-1.lua new file mode 120000 index 000000000..da69ac81c --- /dev/null +++ b/test/replication/replica-quorum-1.lua @@ -0,0 +1 @@ +replica.lua \ No newline at end of file diff --git a/test/replication/replica-quorum-2.lua b/test/replication/replica-quorum-2.lua new file mode 120000 index 000000000..da69ac81c --- /dev/null +++ b/test/replication/replica-quorum-2.lua @@ -0,0 +1 @@ +replica.lua \ No newline at end of file diff --git a/test/replication/replica-quorum-3.lua b/test/replication/replica-quorum-3.lua new file mode 120000 index 000000000..da69ac81c --- /dev/null +++ b/test/replication/replica-quorum-3.lua @@ -0,0 +1 @@ +replica.lua \ No newline at end of file diff --git a/test/replication/replica-quorum-4.lua b/test/replication/replica-quorum-4.lua new file mode 120000 index 000000000..da69ac81c --- /dev/null +++ b/test/replication/replica-quorum-4.lua @@ -0,0 +1 @@ +replica.lua \ No newline at end of file diff --git a/test/replication/replica-quorum-5.lua b/test/replication/replica-quorum-5.lua new file mode 120000 index 000000000..da69ac81c --- /dev/null +++ b/test/replication/replica-quorum-5.lua @@ -0,0 +1 @@ +replica.lua \ No newline at end of file diff --git a/test/replication/replica-quorum-6.lua b/test/replication/replica-quorum-6.lua new file mode 120000 index 000000000..da69ac81c --- /dev/null +++ b/test/replication/replica-quorum-6.lua @@ -0,0 +1 @@ +replica.lua \ No newline at end of file -- 2.26.2