From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7D91F45C305
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  4 Dec 2020 17:35:06 +0300 (MSK)
Date: Fri, 4 Dec 2020 17:35:04 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201204143504.GA5396@tarantool.org>
References: <a0b974caa57b980eddaf94ce26f2c7968855e95b.1607088022.git.imun@tarantool.org>
 <20201204141408.GA20578@root>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201204141408.GA20578@root>
Subject: Re: [Tarantool-patches] [PATCH luajit] x64: Fix __call metamethod
	return dispatch.
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sergey,

Thanks for your review!

On 04.12.20, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the patch!
> LGTM except the single nit.

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>

> 
> On 04.12.20, Igor Munkin wrote:
> > From: Mike Pall <mike>
> > 
> > After linking new cframe to the chain KBASEa still stores the address of
> > the previous one. If the execution proceeds to <lj_vmeta_call> KBASE
> > value (i.e. low 32 bits of the stored address) might be equal to the
> > current BASE address value so the execution takes the invalid path. Such
> > address clashing occurs only on x86_64 platform with disabled LJ_GC64,
> 
> Typo: s/address/address parts/ (considering your message in PR).

Thanks, fixed.

> 
> > so 64-bit registers have to be compared in x64 build.
> > 
> > NB: Though there is only 32-bit load to restore BASE value prior to the
> > comparison, the high 32 bits of RDX are reset to zeros, according to x86
> > long mode semantics.
> > 
> > Igor Munkin:
> > * backported the original patch to tarantool/luajit repo
> > * extended the original commit message with the rationale
> > 
> > For more info and explanation see LuaJIT/LuaJIT#636.
> > 
> > Relates to tarantool/tarantool#4518
> > Relates to tarantool/tarantool#4649
> > 
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
> > ---
> > 

<snipped>

> > 
> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM