Re: [Tarantool-patches] [PATCH v2] test: replication-py/init_storage.test.py

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 02 Dec 23:20, Alexander V. Tikhonov wrote:
> Found that test failed in 2 common places when it tried to start the
> replica and wait it within 'JOIN' either 'SUBSCRIBE' test parts.
> It used to wait for replica start check the 'wait_until_started()'
> function 'TarantoolServer' class from test-run repository. But it
> didn't try resolve connection issues on replica creation, like:
> 
>   [30534] main/103/replica I> connecting to 1 replicas
>   [30534] main/112/applier/localhost:49168 I> can't connect to master
>   [30534] main/112/applier/localhost:49168 sio.c:208 !> SystemError connect to 127.0.0.1:49168, called on fd 27, aka 127.0.0.1:47954: Connection refused
>   [30534] main/112/applier/localhost:49168 I> will retry every 0.10 second
>   [30534] main/112/applier/localhost:49168 I> remote master c5d480c3-219c-11eb-ac14-080027727614 at 127.0.0.1:49168 running Tarantool 2.7.0
>   [30534] main/103/replica I> connected to 1 replicas
>   [30534] main/103/replica I> bootstrapping replica from c5d480c3-219c-11eb-ac14-080027727614 at 127.0.0.1:49168
>   [30534] main/112/applier/localhost:49168 I> can't read row
>   [30534] main/112/applier/localhost:49168 box.cc:183 E> ER_READONLY: Can't modify data because this instance is in read-only mode.
>   [30534] main/103/replica box.cc:183 E> ER_READONLY: Can't modify data because this instance is in read-only mode.
>   [30534] main/103/replica F> can't initialize storage: Can't modify data because this instance is in read-only mode.
>   [30534] main/103/replica F> can't initialize storage: Can't modify data because this instance is in read-only mode.
> 
> To resolve it the test was changed to be able to catch exception
> 'TarantoolStartError' from test-run. Also the test should have the
> ability to be restarted by test-run using fragile list and in this way
> 'crash_expected' flag was enabled to let the test fail with exception.
> 
> Needed by #4949
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4949
> Issue: https://github.com/tarantool/tarantool/issues/4949

I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin