From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 619EC45C304
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  2 Dec 2020 03:27:26 +0300 (MSK)
Date: Wed, 2 Dec 2020 03:27:24 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20201202002724.GA152662@hpalx>
References: <cover.1606479683.git.artemreyt@tarantool.org>
 <20201201141612.GA141163@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201201141612.GA141163@hpalx>
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] GCC 10 fix warnings
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>, Artem Starshov <artemreyt@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Artem, as I see rebase helped to resolve the issues [1], patch LGTM.

[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/223855440

On Tue, Dec 01, 2020 at 05:16:12PM +0300, Alexander V. Tikhonov via Tarantool-patches wrote:
> Hi Artem, thanks for the patch. I see some strange results in OSX and
> FreeBSD testings. It looks like a flaky results, but they are new and
> happens to often, even rerun of the testings could not resolve it.
> Seems that some new hidden issue appeared. Feel free to contact me to
> analyze it [1].
> 
> [1] - https://gitlab.com/tarantool/tarantool/-/pipelines/222165041/builds
> 
> > On Fri, Nov 27, 2020 at 03:43:08PM +0300, Artem Starshov via Tarantool-patches wrote:
> > Artem Starshov (2):
> >   sql: fix build with GCC 10
> >   bitset: replace zero-length array with flexible-array member
> > 
> >  src/box/sql/select.c    | 56 +++++++++++++++++++----------------------
> >  src/lib/bitset/bitset.h |  2 +-
> >  2 files changed, 27 insertions(+), 31 deletions(-)
> > 
> > Issue: https://github.com/tarantool/tarantool/issues/4966
> > Branch: https://github.com/tarantool/tarantool/tree/artemreyt/gh-4966-gcc10-warns
> > -- 
> > 2.28.0
> >