From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3BD5D45C304
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  1 Dec 2020 15:20:34 +0300 (MSK)
Date: Tue, 1 Dec 2020 15:20:33 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201201122033.cqq7pqhpsbrcnt5w@tkn_work_nb>
References: <20201113145648.268768-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201113145648.268768-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH] console: drop unused serpent module
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

Thanks!

Pushed to master.

WBR, Alexander Turenko.

On Fri, Nov 13, 2020 at 05:56:48PM +0300, Cyrill Gorcunov wrote:
> Since the commit ae7e210 we use internal serializer
> thus we no longer need serpent code.
> 
> The patch removes the references from the source code
> and .gitmodules file, still one might need to run
> 
>  | git submodule deinit -f third_party/serpent
> 
> manually to clean up the working tree depending
> on local git version.
> 
> Closes #5517
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> issue https://github.com/tarantool/tarantool/issues/5517
> branch gorcunov/gh-5517-drop-serpent
> 
> Sasha, please take a very close look. While the commit works
> just fine locally we need to double check if submodule removed
> without any clash.

I removed the directory after the commit and everything looks fine.
The relevant recond in .git/config still exists, but can be deleted
manually.