From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9E48F469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 25 Nov 2020 15:12:59 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id b17so2007244ljf.12
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 25 Nov 2020 04:12:59 -0800 (PST)
Date: Wed, 25 Nov 2020 15:12:56 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201125121256.GN875895@grain>
References: <20201124152405.1174898-1-gorcunov@gmail.com>
 <20201124152405.1174898-3-gorcunov@gmail.com>
 <248e1a42-c948-89ca-7894-251583c33246@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <248e1a42-c948-89ca-7894-251583c33246@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 2/3] cfg: support symbolic
 evaluation of replication_synchro_quorum
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Wed, Nov 25, 2020 at 03:04:07PM +0300, Serge Petrenko wrote:
>=20
> Just noticed. Looks like this diag_set and the one below are ignored:
> ```
> tarantool> a=3Dstring.rep('n', 1000)
> ---
> ...
>=20
> tarantool> box.cfg{replication_synchro_quorum=3Da}
> ---
> - error: 'Incorrect value for option ''replication_synchro_quorum'': the
> value must
> =A0=A0=A0 be greater than zero and less than maximal number of replicas'
> ...

Indeed. Actually if you remember I've been using errno for such errors.
Now we either should call diag_log() right after diag_set or return
errno handling?