From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 36952469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 25 Nov 2020 00:41:10 +0300 (MSK)
Date: Wed, 25 Nov 2020 00:41:08 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20201124214108.GA146635@hpalx>
References: <20201112195121.191366-1-gorcunov@gmail.com>
 <1151e858-0e68-e648-f095-44b72ffd674e@tarantool.org>
 <20201124065247.GK875895@grain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201124065247.GK875895@grain>
Subject: Re: [Tarantool-patches] [PATCH 00/11] qsync: code refactoring
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

Hi Cyrill, thanks for the patch, as I see no new degradation found in
gitlab-ci testing commit criteria pipeline [1], patch LGTM.

[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/220256606

On Tue, Nov 24, 2020 at 09:52:47AM +0300, Cyrill Gorcunov wrote:
> On Tue, Nov 24, 2020 at 12:26:04AM +0100, Vladislav Shpilevoy wrote:
> > Hi!
> > 
> > Alexander (Tikh.), please, validate that we can push branch
> > gorcunov/qsync-refactoring, to which I cherry-picked the
> > LGTM commits.
> > 
> > Cyrill, for the first commit I don't know what to do.
> > All the files you listed you use personally in your
> > workspace, it seems. If we would add everything what we
> > have locally there, the file would end up as a pile of
> > garbage. I can't make a decision to push anything new there.
> > I suggest you to send it to somebody else. For example,
> > Alexander (Turenko).
> 
> Vlad, I'm pretty fine if we simply drop the series. Sorry
> if I was somehow emotional in my replies :)
> 
> I think the main reason for series was my attempt to figure
> out some limbo internals especially rollback and queue management,
> so the series is a side effect. Lets just rip the series off and forget )