From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 293F2469710 for ; Tue, 24 Nov 2020 18:20:58 +0300 (MSK) Date: Tue, 24 Nov 2020 18:20:54 +0300 From: Igor Munkin Message-ID: <20201124152054.GF14086@tarantool.org> References: <696b028492d8c1e680a3386c87534d96eac7c272.1605685304.git.babinoleg@mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <696b028492d8c1e680a3386c87534d96eac7c272.1605685304.git.babinoleg@mail.ru> Subject: Re: [Tarantool-patches] [PATCH v2 2/2] uuid: support uuid comparison with strings List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: olegrok@tarantool.org Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Oleg, Thanks for the patch! Considering the version on the remote branch, LGTM except a single nit below. On 18.11.20, olegrok@tarantool.org wrote: > From: Oleg Babin > > Before this patch it was impossible to compare uuid values with > string representations of uuid. However we have cases when such > comparisons is possible (e.g. "decimal" where we can compare > decimal values with strings and numbers). > > This patch extends uuid comparators (eq, lt, le) and every string Minor: Strictly saying, you're right, but AFAICS we usually use the key name (i.e. __eq, __le and __lt) for metamethods in description. > argument is tried to be converted to uuid value to compare then. > > Follow-up #5511 > > @TarantoolBot document > Title: uuid values could be compared with strings > > Currently it's possible to compare uuid values with its string > representations: > ```lua > u1_str = 'aaaaaaaa-aaaa-4000-b000-000000000001' > u1 = uuid.fromstr(u1_str) > u2_str = 'bbbbbbbb-bbbb-4000-b000-000000000001' > > u1 == u1_str -- true > u1 == u2_str -- false > > u1 >= u1_str -- true > u1 < u2_str -- true > ``` > --- > Issue: https://github.com/tarantool/tarantool/issues/5511 > Branch: https://github.com/tarantool/tarantool/tree/olegrok/5511-uuid-cmp-v2 > > src/lua/uuid.lua | 31 +++++++++++++-- > test/app/uuid.result | 85 ++++++++++++++++++++++++++++++++++++++---- > test/app/uuid.test.lua | 27 ++++++++++++++ > 3 files changed, 131 insertions(+), 12 deletions(-) > > -- > 2.29.0 > -- Best regards, IM