From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 139F5469710 for ; Tue, 24 Nov 2020 09:52:51 +0300 (MSK) Received: by mail-lf1-f68.google.com with SMTP id d20so11440018lfe.11 for ; Mon, 23 Nov 2020 22:52:50 -0800 (PST) Date: Tue, 24 Nov 2020 09:52:47 +0300 From: Cyrill Gorcunov Message-ID: <20201124065247.GK875895@grain> References: <20201112195121.191366-1-gorcunov@gmail.com> <1151e858-0e68-e648-f095-44b72ffd674e@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1151e858-0e68-e648-f095-44b72ffd674e@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 00/11] qsync: code refactoring List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tml On Tue, Nov 24, 2020 at 12:26:04AM +0100, Vladislav Shpilevoy wrote: > Hi! > > Alexander (Tikh.), please, validate that we can push branch > gorcunov/qsync-refactoring, to which I cherry-picked the > LGTM commits. > > Cyrill, for the first commit I don't know what to do. > All the files you listed you use personally in your > workspace, it seems. If we would add everything what we > have locally there, the file would end up as a pile of > garbage. I can't make a decision to push anything new there. > I suggest you to send it to somebody else. For example, > Alexander (Turenko). Vlad, I'm pretty fine if we simply drop the series. Sorry if I was somehow emotional in my replies :) I think the main reason for series was my attempt to figure out some limbo internals especially rollback and queue management, so the series is a side effect. Lets just rip the series off and forget )