From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com
 [209.85.167.67])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 65BBA469710
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 21 Nov 2020 15:10:02 +0300 (MSK)
Received: by mail-lf1-f67.google.com with SMTP id 74so17268726lfo.5
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 21 Nov 2020 04:10:02 -0800 (PST)
Date: Sat, 21 Nov 2020 15:09:58 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201121120958.GA935718@grain>
References: <20201112195121.191366-1-gorcunov@gmail.com>
 <20201112195121.191366-2-gorcunov@gmail.com>
 <c836fa2b-b807-9fe1-e27e-3c537df9e8fe@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c836fa2b-b807-9fe1-e27e-3c537df9e8fe@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 01/11] build: add more ignore paths
 for tags target
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Sat, Nov 21, 2020 at 12:55:10AM +0100, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> On 12.11.2020 20:51, Cyrill Gorcunov wrote:
> > Our .gitignore has been extended recently lets
> > add more paths to skip when building the tags
> > target.
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > ---
> >  CMakeLists.txt | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > index fa6818f8e..84f77dc2b 100644
> > --- a/CMakeLists.txt
> > +++ b/CMakeLists.txt
> > @@ -150,6 +150,12 @@ check_function_exists(getprogname HAVE_GETPROGNAME)
> >  list(APPEND tagsExclude "--exclude=.git/*")
> >  list(APPEND tagsExclude "--exclude=.pc/*")
> >  list(APPEND tagsExclude "--exclude=patches/*")
> > +list(APPEND tagsExclude "--exclude=.git-ignore/*")
> 
> What is this? I don't see it locally. So it is not generated, correct?
> The same for 'coverity/', 'coverage/', '.idea' - I don't see then appearing
> when I compile.

These are service directories. Coverity and coverage are for appropriate
tools, .git-ignore for the things you don't want to commit but prefer to
keep in source tree (yes this happens when you need to test something).