From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 48E41469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Nov 2020 11:15:17 +0300 (MSK)
Date: Thu, 19 Nov 2020 11:15:23 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201119081523.jzkoepoewi4h52bi@tkn_work_nb>
References: <ed3a462eab028de11cea256c8f0efe5bb1ff2c0c.1604995527.git.alexander.turenko@tarantool.org>
 <05c701d6bcbd$0df4dbc0$29de9340$@tarantool.org>
 <20201117122548.oj3xd4vdtb4a5mfn@tkn_work_nb>
 <20201118122749.GA34133@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201118122749.GA34133@hpalx>
Subject: Re: [Tarantool-patches] [PATCH] lua/merger: fix NULL dereferences
	on error paths
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Thanks!

Pushed to master, 2.6, 2.5.

Added changelog entries:

 | * Fixed NULL dereference on error paths in merger, usually on a
 |   'wrong' key_def (gh-5450).

WBR, Alexander Turenko.

On Wed, Nov 18, 2020 at 03:27:49PM +0300, Alexander V. Tikhonov wrote:
> Hi Alexander, thanks for the patch, as I see no new degradations found in
> gitlab-ci testing commit criteria pipeline [1], patch LGTM.
> 
> [1] - https://gitlab.com/tarantool/tarantool/-/pipelines/217180398
> 
> On Tue, Nov 17, 2020 at 03:25:48PM +0300, Alexander Turenko wrote:
> > Alexander,
> > 
> > I need your approve before I'll push the patch.
> > 
> > The branch is Totktonada/gh-5450-merger-segfault-on-wrong-key-def. I
> > rebased it upward the latest master and force-pushed today, because
> > gh-5473 was resolved.
> > 
> > CentOS 7 jobs ('centos_7', 'default_gcc_centos_7') failed due to a
> > problem with vault repository. Fixed in [1] and restarted. They passed
> > after it.
> > 
> > 'debug' job failed on engine/ddl.test.lua. Looks similar to [2].
> > 
> > 'freebsd_12_release' job failed on replication/election_qsync.test.lua.
> > Looks similar to [3].
> > 
> > Mac OS 10.15 jobs ('osx_15_release', 'osx_15_release_lto',
> > 'static_build_cmake_osx_15') are still pending.
> > 
> > [1]: https://github.com/packpack/packpack-docker-images/pull/62
> > [2]: https://github.com/tarantool/tarantool/issues/4353
> > [3]: https://github.com/tarantool/tarantool/issues/5430
> > 
> > WBR, Alexander Turenko.