From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 22594469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 18 Nov 2020 20:24:00 +0300 (MSK)
Date: Wed, 18 Nov 2020 20:23:58 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20201118172358.GA53565@hpalx>
References: <20200403152752.8923-1-roman.habibov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200403152752.8923-1-roman.habibov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Support column addition with
 <ALTER TABLE>
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Roman, thanks for the patchset, as I see no new degradations found
in gitlab-ci testing commit criteria pipeline [1]. Test jobs based on
opensuse failed because of external issues and already checked at [2],
patch LGTM.

[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/218019328
[2] - https://gitlab.com/tarantool/tarantool/-/pipelines/217893488

On Fri, Apr 03, 2020 at 06:27:50PM +0300, Roman Khabibov wrote:
> According to the SQL standard, column definition in a
> <CREATE TABLE> and a <ALTER TABLE ADD COLUMN> is the same. So, I
> decided to support Tarantool features like AUTOINCREMENT in the
> alter column description.
> 
> Roman Khabibov (2):
>   sql: rename TK_COLUMN to TK_COLUMN_NAME
>   sql: support column addition
> 
>  extra/addopcodes.sh          |   2 +-
>  extra/mkkeywordhash.c        |   5 +-
>  src/box/errcode.h            |   2 +
>  src/box/schema_def.h         |   1 +
>  src/box/sql/alter.c          |   1 +
>  src/box/sql/build.c          | 596 +++++++++++++++++++++++------------
>  src/box/sql/expr.c           |  42 +--
>  src/box/sql/fk_constraint.c  |   2 +-
>  src/box/sql/parse.y          |  45 ++-
>  src/box/sql/parse_def.h      |  62 ++--
>  src/box/sql/prepare.c        |   8 +-
>  src/box/sql/resolve.c        |  10 +-
>  src/box/sql/select.c         |  10 +-
>  src/box/sql/sqlInt.h         |  58 +++-
>  src/box/sql/treeview.c       |   2 +-
>  src/box/sql/where.c          |  18 +-
>  src/box/sql/whereexpr.c      |  12 +-
>  test/box/error.result        |   2 +
>  test/sql/add-column.result   | 231 ++++++++++++++
>  test/sql/add-column.test.lua |  87 +++++
>  20 files changed, 892 insertions(+), 304 deletions(-)
>  create mode 100644 test/sql/add-column.result
>  create mode 100644 test/sql/add-column.test.lua
> 
> -- 
> 2.21.0 (Apple Git-122)
>