From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1DFD9469719 for ; Fri, 13 Nov 2020 20:56:13 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id w142so15138263lff.8 for ; Fri, 13 Nov 2020 09:56:13 -0800 (PST) Date: Fri, 13 Nov 2020 20:56:07 +0300 From: Cyrill Gorcunov Message-ID: <20201113175607.GJ2021@grain> References: <20201105151808.456573-1-gorcunov@gmail.com> <20201105151808.456573-2-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v10 1/4] box/func: factor out c function entry structure List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tml On Thu, Nov 12, 2020 at 11:53:40PM +0100, Vladislav Shpilevoy wrote: > > Please, never squash refatoring and a bugfix into a single commit. > That makes the commit not atomic, and creates problems with > backporting such commit, which is clearly needed here. > > Move the bugfix to a separate commit which can be cherry-picked to > the older versions. Done. Resent as a separate patch. Note though that we will need to merge it first before I'll be able to continue since this change is blocking for the series.