From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com
 [209.85.167.46])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7618F469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 20:54:38 +0300 (MSK)
Received: by mail-lf1-f46.google.com with SMTP id z21so15124913lfe.12
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 09:54:38 -0800 (PST)
Date: Fri, 13 Nov 2020 20:54:33 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201113175433.GI2021@grain>
References: <20201105151808.456573-1-gorcunov@gmail.com>
 <f79fcb24-6d67-ab2d-7eed-e0a8f4e8f9cd@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f79fcb24-6d67-ab2d-7eed-e0a8f4e8f9cd@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v10 0/4] box/cbox: implement cfunc
 Lua module
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, Nov 12, 2020 at 11:53:35PM +0100, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patchset!
> 
> I am going to ask you to send responses to my comments in a
> format of diff hunks fixing the comments. Usually you rush to
> answer to my comments the same day they are sent with some
> promises like "I will take a look", "I will see what can be done",
> etc. But then you send a new version of the patchset without
> responding to my comments with what you actually did regarding
> each of them.
> 
> That makes me go through the comments on my own and look for the
> commented places in the new patch to see the difference. It takes
> significant time.
> 
> https://github.com/tarantool/tarantool/wiki/Code-review-procedure#during-the-review
> Point 1.

OK. I did the whole resend simply thought you gonna be more comfortable with.