From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com
 [209.85.167.68])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 85CCC469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 13:28:49 +0300 (MSK)
Received: by mail-lf1-f68.google.com with SMTP id v144so12991997lfa.13
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 02:28:49 -0800 (PST)
Date: Fri, 13 Nov 2020 13:28:46 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201113102846.GE2021@grain>
References: <20201112195121.191366-1-gorcunov@gmail.com>
 <20201112195121.191366-11-gorcunov@gmail.com>
 <07fbedb0-9d4f-893f-a8b4-db6eac975428@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <07fbedb0-9d4f-893f-a8b4-db6eac975428@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 10/11] relay: use verbose names for
	fibers
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Fri, Nov 13, 2020 at 01:17:29PM +0300, Serge Petrenko wrote:
> 
> 12.11.2020 22:51, Cyrill Gorcunov пишет:
> > Usually we use _f postfix for fiber's loop functions
> > and using same postfix for the fiber instance itself
> > looks inconsistent.
> > 
> > Same time if we grep for "struct fibers" we see a number
> > of places where fiber instances are postfixed with _fiber.
> > 
> > Thus lets make the same in relay fiber code:
> > 
> >   - use explicit reader_fiber name for a reader
> >   - use relay_fiber name for the joint relay fiber
> >     which depends on the reader, moreover this explicit
> >     name allows to note that the reader cancels the bound
> >     fiber if error happens.
> 
> Applier also has incosistent naming. applier->reader and applier->writer.
> 
> Maybe apply the same naming for relay? Make relay_f relay_writer.
> And reader_fiber -> relay_reader. It looks better in my opinion.

Yeah, I though of this as well. Lets drop this patch. Actually I
suspect we gonna withdraw the whole series, except the last patch
where we fix a real bug in say_info for raft. Up to you guys.