From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2AAD8469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 13:13:40 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id x9so10006244ljc.7
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 02:13:40 -0800 (PST)
Date: Fri, 13 Nov 2020 13:13:37 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201113101337.GD2021@grain>
References: <20201112195121.191366-1-gorcunov@gmail.com>
 <20201112195121.191366-10-gorcunov@gmail.com>
 <11e6dccd-feba-e55c-4f0b-0d73e50d8b6d@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <11e6dccd-feba-e55c-4f0b-0d73e50d8b6d@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 09/11] qsync: drop redundant type
	convention
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Fri, Nov 13, 2020 at 01:11:05PM +0300, Serge Petrenko wrote:
> 
> 12.11.2020 22:51, Cyrill Gorcunov пишет:
> > Void pointer can be cast implicitly.
> 
> We usually use explicit casts. Check `applier.cc`, `alter.cc` and some other
> places.
> This isn't in our style guide though, so I'm fine with the change.
> 
> Let's see what Vlad has to say.

The casts are required for C++ but for plain C void pointer can be
casted to anything, as it is guaranteed by language standart. So
such casting is simply not needed.