From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com
 [209.85.167.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 967B7469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 13:12:16 +0300 (MSK)
Received: by mail-lf1-f66.google.com with SMTP id l11so909733lfg.0
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 02:12:16 -0800 (PST)
Date: Fri, 13 Nov 2020 13:12:13 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201113101213.GC2021@grain>
References: <20201112195121.191366-1-gorcunov@gmail.com>
 <20201112195121.191366-8-gorcunov@gmail.com>
 <025b90cb-64ae-8525-82d5-1fdc20ee3ff7@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <025b90cb-64ae-8525-82d5-1fdc20ee3ff7@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 07/11] qsync: move limbo owner
 transition into separate helper
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Fri, Nov 13, 2020 at 12:47:59PM +0300, Serge Petrenko wrote:
> 
> AFAIK we use `return 0/-1` for such functions. bool is only used for
> something that
> really returns true or false, like `field_mp_type_is_compatible()`.
> 
> Other than that the patch looks good.

OK, thanks!