From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com
 [209.85.167.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 67B92469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 13:11:44 +0300 (MSK)
Received: by mail-lf1-f66.google.com with SMTP id u18so12957737lfd.9
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 02:11:44 -0800 (PST)
Date: Fri, 13 Nov 2020 13:11:41 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201113101141.GB2021@grain>
References: <20201112195121.191366-1-gorcunov@gmail.com>
 <20201112195121.191366-7-gorcunov@gmail.com>
 <bbc03c9f-b080-c4d7-bc4d-8e5586e54d86@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bbc03c9f-b080-c4d7-bc4d-8e5586e54d86@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 06/11] qsync: txn_limbo_append --
 use owner_id in argument name
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Fri, Nov 13, 2020 at 12:43:02PM +0300, Serge Petrenko wrote:
> 
> 12.11.2020 22:51, Cyrill Gorcunov пишет:
> > And change the callers. This id is needed to test for
> > foreign keys and to set limbo owner on demand.
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > ---
> 
> Hi! Thanks for the patch!
> 
> Don't do that, please.
> Now it looks like you're getting a limbo by its owner id and
> insert data there.
> 
> This may be the case someday, but now we have a single limbo,
> and we may try to insert data with any instance id there (and fail,
> if the instance id doesn't match limbo owner id).

OK, sure!