From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 3/3] replication: add test with random leaders promotion and demotion
Date: Thu, 12 Nov 2020 12:32:09 +0300 [thread overview]
Message-ID: <20201112093209.GB25937@pony.bronevichok.ru> (raw)
In-Reply-To: <9b889490-07da-9afc-cf2e-16d6700d255c@tarantool.org>
Hi, Sergey!
Fixes applied in updated patch [1]
1. https://lists.tarantool.org/pipermail/tarantool-patches/2020-November/020636.html
On 16:03 Tue 01 Sep , Serge Petrenko wrote:
> > -- Testcase body.
> > for i=1,100 do \
> > test_run:eval(SERVERS[current_leader_id], \
> > "box.cfg{replication_synchro_quorum=6}") \
> > test_run:eval(SERVERS[current_leader_id], \
> > string.format("box.space.sync:insert{%d}", i)) \
> > new_leader_id = random(current_leader_id, 1, #SERVERS) \
> > test_run:eval(SERVERS[new_leader_id], \
> > "box.cfg{replication_synchro_quorum=3}") \
> > test_run:eval(SERVERS[new_leader_id], "box.ctl.clear_synchro_queue()") \
> > replica = random(new_leader_id, 1, #SERVERS) \
> > test_run:eval(SERVERS[replica], \
> > string.format("box.space.sync:get{%d}", i)) \
>
> It is not checked whether get returns any data or not.
> You only make a call but never check the return value.
>
> It'd also be nice to check whether the insert on the old leader (the one
> with
> quorum = 6) succeeds after the new leader executes `clear_synchro_queue`.
Added two wait_cond() to check value on a random replica and old leader.
Additionally expected total number of values checked right after the loop with
box.space.sync:count().
prev parent reply other threads:[~2020-11-12 9:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1594314820.git.sergeyb@tarantool.org>
2020-07-09 17:16 ` [Tarantool-patches] [PATCH 1/3] replication: print number of txs in limbo before its clear sergeyb
2020-07-09 20:07 ` Vladislav Shpilevoy
2020-07-10 12:55 ` Sergey Bronnikov
2020-07-20 21:59 ` Vladislav Shpilevoy
2020-07-09 17:16 ` [Tarantool-patches] [PATCH 2/3] replication: test clear_synchro_queue function sergeyb
2020-07-20 22:00 ` Vladislav Shpilevoy
2020-08-25 12:49 ` Sergey Bronnikov
2020-08-26 7:31 ` Serge Petrenko
2020-08-26 14:48 ` Sergey Bronnikov
2020-07-09 17:16 ` [Tarantool-patches] [PATCH 3/3] replication: add test with random leaders promotion and demotion sergeyb
2020-07-09 20:07 ` Vladislav Shpilevoy
2020-07-10 8:05 ` Sergey Bronnikov
2020-07-20 22:01 ` Vladislav Shpilevoy
2020-08-26 14:45 ` Sergey Bronnikov
2020-08-27 10:49 ` Serge Petrenko
2020-08-31 10:05 ` Sergey Bronnikov
2020-09-01 13:03 ` Serge Petrenko
2020-11-12 9:32 ` Sergey Bronnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112093209.GB25937@pony.bronevichok.ru \
--to=sergeyb@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/3] replication: add test with random leaders promotion and demotion' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox