Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Artem <artemreyt@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] luacheck: change global vars to local in sql-tap
Date: Wed, 11 Nov 2020 14:53:40 +0300	[thread overview]
Message-ID: <20201111115340.xxhad6n6nmmdbk4o@tkn_work_nb> (raw)
In-Reply-To: <f70443a5-b1ba-5269-e0c8-5794616261cf@tarantool.org>

> diff --git a/test/sql-tap/trigger2.test.lua b/test/sql-tap/trigger2.test.lua
> index 192b707d3..e58af5543 100755
> --- a/test/sql-tap/trigger2.test.lua
> +++ b/test/sql-tap/trigger2.test.lua
> @@ -61,8 +61,8 @@ test:plan(26)
>  
>  box.space._session_settings:update('sql_recursive_triggers', {{'=', 2, false}})
>  -- 1.
> -ii = 0
> -tbl_definitions = { "CREATE TABLE tbl (id INT PRIMARY KEY AUTOINCREMENT, a INTEGER UNIQUE, b INT );",
> +local ii = 0
> +local tbl_definitions = { "CREATE TABLE tbl (id INT PRIMARY KEY AUTOINCREMENT, a INTEGER UNIQUE, b INT );",
>                      "CREATE TABLE tbl (id INT PRIMARY KEY AUTOINCREMENT, a INT UNIQUE, b INT );",
>                      "CREATE TABLE tbl (id INT PRIMARY KEY AUTOINCREMENT, a INT, b INT UNIQUE );",
>                      "CREATE TABLE tbl (id INT PRIMARY KEY AUTOINCREMENT, a INT, b INTEGER UNIQUE );"}

Nit: CREATE TABLE statements were indented on the same column, but now
they're not.

  parent reply	other threads:[~2020-11-11 11:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 11:25 Artem Starshov
2020-10-23 12:09 ` Sergey Bronnikov
2020-11-04 17:44   ` Artem
2020-11-05 23:46     ` Alexander Turenko
2020-11-09 14:38       ` Artem
2020-11-10 14:09         ` Sergey Bronnikov
2020-11-12 12:04           ` Artem
2020-11-11 11:53         ` Alexander Turenko [this message]
2020-11-11  8:17       ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201111115340.xxhad6n6nmmdbk4o@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=artemreyt@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] luacheck: change global vars to local in sql-tap' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox