From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AE0DA469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 11 Nov 2020 11:17:09 +0300 (MSK)
Date: Wed, 11 Nov 2020 11:17:13 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201111081713.ealg65wtrk7x77ec@tkn_work_nb>
References: <6e71b54cc1c314746dfe9ff143bfcff6f9d0aeca.1603106269.git.artemreyt@tarantool.org>
 <20201023120931.GA17385@pony.bronevichok.ru>
 <4c35f2f2-901b-da2f-1ac5-312b59a300e1@tarantool.org>
 <20201105234659.dpwskwt5diulzphv@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201105234659.dpwskwt5diulzphv@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH] luacheck: change global vars to
 local in sql-tap
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Artem <artemreyt@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Fri, Nov 06, 2020 at 02:47:00AM +0300, Alexander Turenko wrote:
> Thanks for the effort!
> 
> Just `luacheck .` shows the following warnings, for example:
> 
> test/sql-tap/minmax2.test.lua:64:9: setting non-standard global variable sql_search_count
> test/sql-tap/subquery.test.lua:696:9: setting non-standard global variable callcnt
> 
> It seems, `make luacheck` target does not work.
> 
>  | $ make VERBOSE=1 luacheck
>  | <...>
>  | /usr/bin/luacheck --codes --config                \
>  |     /home/alex/p/tarantool-meta/r/t-3/.luacheckrc \
>  |     /home/alex/p/tarantool-meta/r/t-3
>  | <...>
> 
> If I run luacheck this way, it does not give any warnings. This does not
> look as the problem from your patch, but it is something we should fix
> prior it.

Found problems on the luacheck side (at least it looks so) and
implemented the workaround for tarantool:

https://github.com/mpeterv/luacheck/issues/208
https://github.com/tarantool/tarantool/commit/a1d2ce9a758ac1bbf7173cf197eea3f1556b7cb4

The workaround looks a bit tricky, so I'm not sure whether it worth to
push it. I'll think around it a bit more and maybe will sent it for
review.