From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id F2517469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 11 Nov 2020 00:09:10 +0300 (MSK)
Date: Wed, 11 Nov 2020 00:09:08 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20201110210908.GC25467@hpalx>
References: <cover.1604767356.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1604767356.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] Raft crash on re-enablence
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Vlad, I've checked all results in gitlab-ci, and no new degradations
found [1], patch LGTM.

[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/213913895

On Sat, Nov 07, 2020 at 05:45:30PM +0100, Vladislav Shpilevoy wrote:
> The patchset fixes 2 crashes related to Raft WAL write being in progress,
> when the state machine is restarted, and when it is configured to be a candidate
> with a known leader.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5506-raft-crash
> Issue: https://github.com/tarantool/tarantool/issues/5506
> 
> @ChangeLog
> * Fixed a couple of crashes on various tweaks of election mode (gh-5506).
> 
> Vladislav Shpilevoy (2):
>   raft: fix crash on sm restart during WAL write
>   raft: fix crash on candidate cfg during WAL write
> 
>  src/box/raft.c                                |  23 ++-
>  .../gh-5506-election-on-off.result            | 140 ++++++++++++++++++
>  .../gh-5506-election-on-off.test.lua          |  68 +++++++++
>  test/replication/suite.cfg                    |   1 +
>  test/replication/suite.ini                    |   2 +-
>  5 files changed, 225 insertions(+), 9 deletions(-)
>  create mode 100644 test/replication/gh-5506-election-on-off.result
>  create mode 100644 test/replication/gh-5506-election-on-off.test.lua
> 
> -- 
> 2.21.1 (Apple Git-122.3)
>