From: Kirill Yukhin <kyukhin@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 5/5] Apply Clang formatter Date: Tue, 10 Nov 2020 14:16:51 +0000 [thread overview] Message-ID: <20201110141651.sa7al2ms7ggx2jxe@tarantool.org> (raw) In-Reply-To: <e9c793a7-304e-6624-820a-3b114bec0571@tarantool.org> Hello, On 02 Nov 22:05, Vladislav Shpilevoy wrote: > Ok. I will review the whole patch, every single line. Don't push > it beforehand then. In my previous e-mail I've explicitly stated that current formatter is not suitable for us. Quote: >> After all, having p.3 and p.8 unresolved I guess we cannot proceed >> without changes to formatter. Please, see what does it mean here [1]. [1] - https://translate.google.com/#view=home&op=translate&sl=auto&tl=ru&text=After%20all%2C%20having%20p.3%20and%20p.8%20unresolved%20I%20guess%20we%20cannot%20proceed%20without%20changes%20to%20formatter. -- Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-11-10 14:16 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-30 11:43 [Tarantool-patches] [PATCH 0/5] Add clang format Kirill Yukhin 2020-10-30 11:43 ` [Tarantool-patches] [PATCH 1/5] clang-format: guard various declarations Kirill Yukhin 2020-11-08 15:09 ` Vladislav Shpilevoy 2020-10-30 11:43 ` [Tarantool-patches] [PATCH 2/5] Add .clang-format for src/box/ Kirill Yukhin 2020-10-30 11:43 ` [Tarantool-patches] [PATCH 3/5] build: add clang-format rules Kirill Yukhin 2020-11-08 15:09 ` Vladislav Shpilevoy 2020-10-30 11:43 ` [Tarantool-patches] [PATCH 4/5] gitlab-ci: add code style check Kirill Yukhin 2020-10-30 11:43 ` [Tarantool-patches] [PATCH 5/5] Apply Clang formatter Kirill Yukhin 2020-10-30 13:42 ` Konstantin Osipov 2020-10-30 23:04 ` Vladislav Shpilevoy 2020-11-01 21:40 ` Konstantin Osipov 2020-11-02 7:35 ` Kirill Yukhin 2020-11-02 21:05 ` Vladislav Shpilevoy 2020-11-10 14:16 ` Kirill Yukhin [this message] 2020-11-10 20:38 ` Vladislav Shpilevoy 2020-11-11 8:23 ` Kirill Yukhin 2020-11-08 15:11 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201110141651.sa7al2ms7ggx2jxe@tarantool.org \ --to=kyukhin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 5/5] Apply Clang formatter' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox