From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AFBB8469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  9 Nov 2020 17:27:21 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id y25so9640441lja.9
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 09 Nov 2020 06:27:21 -0800 (PST)
Date: Mon, 9 Nov 2020 17:27:17 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201109142717.GJ2339@grain>
References: <cover.1604858551.git.v.shpilevoy@tarantool.org>
 <8642a26fc2530318c1ef755d706d6bedc9d59684.1604858551.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8642a26fc2530318c1ef755d706d6bedc9d59684.1604858551.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/4] fiber: introduce fiber.arg
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Sun, Nov 08, 2020 at 07:03:54PM +0100, Vladislav Shpilevoy wrote:
> @@ -565,7 +565,19 @@ struct fiber {
>  	 * See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31488
>  	 */
>  	fiber_func f;
> -	va_list f_data;
> +	union {
> +		/**
> +		 * Argument list passed when the fiber is invoked in a blocking
> +		 * way, so the caller may pass arguments from its own stack.
> +		 */
> +		va_list f_data;
> +		/**
> +		 * Fiber function argument which passed asynchronously. Can be
> +		 * used not to call fiber_start to avoid yields, but still pass
> +		 * something into the fiber.
> +		 */
> +		void *arg;

Won't be better to call it "f_arg" instead? To match f_ prefix used in f_data.
This gonna be more suitable for grepping. Since such rename would cause you
to update other patches up to you, if you prefer plain "arg" I'm ok.

Ack