From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BCFA6469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  3 Nov 2020 00:47:23 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id y16so16750084ljk.1
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 02 Nov 2020 13:47:23 -0800 (PST)
Date: Tue, 3 Nov 2020 00:47:20 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201102214720.GF2339@grain>
References: <FBB23D13-1A0D-4C92-918A-EB2995E2CB17@tarantool.org>
 <429b3e4d-490d-ea88-946a-fc0487f9e46a@tarantool.org>
 <20201102131945.GB517@tarantool.org>
 <fd5efc02-a732-ab08-d502-257140674ed6@tarantool.org>
 <20201102211828.GE2339@grain>
 <db9059d8-86a7-8abf-241a-400436d511c3@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <db9059d8-86a7-8abf-241a-400436d511c3@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] core: fix static_alloc buffer
 overflow
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Mon, Nov 02, 2020 at 10:43:02PM +0100, Vladislav Shpilevoy wrote:
> > 
> > Guys, I didn't follow the details of the series but thought of some
> > helper like below. Will it help?
> 
> In some places yes. But SNPRINT is used not only with snprintf.
> 
> It also is used with vsnprintf, mp_snprint, vy_run_snprint_filename,
> tuple_snprint, say_format_plain_tail, json_escape, strftime, and probably
> more. So it would be better to fix SNPRINT. To cover all its usage
> cases.

OK, sounds reasonable.