From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] lua: handle fiber cancellation for fiber.cond
Date: Thu, 29 Oct 2020 21:06:52 +0300 [thread overview]
Message-ID: <20201029180652.pn2myjqbnfambevo@tkn_work_nb> (raw)
In-Reply-To: <20201029171437.GA517@tarantool.org>
On Thu, Oct 29, 2020 at 08:14:37PM +0300, Sergey Ostanevich wrote:
> Hi Oleg!
>
> Thanks for the comment, I believe I have to resend the patch along with
> C API changes.
>
> What I see at the moment - failures like
>
> [076] test_run:wait_upstream(1, {message_re = 'Missing %.xlog file',
> status = 'loading'})
> [076] ---
> [076] -- true
> [076] +- false
>
> which incurred by the intended behavior change, AFAIU. We no longer
> return 'true' in case the fiber is cancelled. The wait_upstream returns
> the cond wait result, hence the output differs.
It just a loop with sleeps. I don't see any relation to your change. If
the fail is stable, it should be the reason to investigate it.
If it is actually intended behaviour change (I doubt that it is so), you
should fix the test.
next prev parent reply other threads:[~2020-10-29 18:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 16:22 sergos
2020-10-28 17:14 ` Oleg Babin
2020-10-29 17:14 ` Sergey Ostanevich
2020-10-29 18:06 ` Alexander Turenko [this message]
2020-10-30 6:47 ` Oleg Babin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029180652.pn2myjqbnfambevo@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua: handle fiber cancellation for fiber.cond' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox