From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1C37F469719 for ; Thu, 22 Oct 2020 19:42:47 +0300 (MSK) Date: Thu, 22 Oct 2020 19:42:44 +0300 From: "Alexander V. Tikhonov" Message-ID: <20201022164244.GA667662@hpalx> References: <1603382553-5570-1-git-send-email-alyapunov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603382553-5570-1-git-send-email-alyapunov@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 0/2] Fix transaction manager List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandr Lyapunov Cc: tarantool-patches@dev.tarantool.org Hi Aleksandr, thanks for the patch. As I see it really fixed the issue [1], and no new degradations occurred. Patchset LGTM. [1] - https://gitlab.com/tarantool/tarantool/-/pipelines/206407310 On Thu, Oct 22, 2020 at 07:02:31PM +0300, Aleksandr Lyapunov wrote: > There was two issues: > * https://github.com/tarantool/tarantool/issues/5423 > * tx_man test faild on OSX builds > > Both problems are fixed now. > > Branch: alyapunov/gh-5423-dirty-tuple-unref > > Aleksandr Lyapunov (2): > memtx: fix a bug in unlinking story lists > memtx: fix a bug in TX that caused deletion of a durty tuple > > src/box/memtx_space.c | 1 + > src/box/memtx_tx.c | 67 +++++++++++++++++++++++++++++++++++++++--------- > test/box/tx_man.result | 43 +++++++++++++++++++++++++++++++ > test/box/tx_man.test.lua | 16 ++++++++++++ > 4 files changed, 115 insertions(+), 12 deletions(-) > > -- > 2.7.4 >