From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C1DA0469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 21 Oct 2020 20:06:16 +0300 (MSK)
Date: Wed, 21 Oct 2020 17:06:15 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20201021170615.GB28675@tarantool.org>
References: <1603101096-18698-1-git-send-email-alyapunov@tarantool.org>
 <20201020010157.GA22095@tarantool.org>
 <20201021170259.GA364452@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201021170259.GA364452@hpalx>
Subject: Re: [Tarantool-patches] [PATCH 0/2] Make tree hint optional
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 21 Oct 20:02, Alexander V. Tikhonov wrote:
> Hi Aleksandr, thanks for the patch. As I see in results it doesn't have
> any new degradations[1]. Patchset LGTM.
> 
> https://gitlab.com/tarantool/tarantool/-/pipelines/205874308

Pushed to master, changelog is updated, original branch is dropped.
 
> On Tue, Oct 20, 2020 at 01:01:57AM +0000, Nikita Pettik wrote:
> > On 19 Oct 12:51, Aleksandr Lyapunov wrote:
> > > https://github.com/tarantool/tarantool/issues/4927
> > > https://github.com/tarantool/tarantool/tree/alyapunov/gh-4927-optional-hints
> > 
> > Release fails to build:
> > https://gitlab.com/tarantool/tarantool/-/jobs/798546360
> > https://gitlab.com/tarantool/tarantool/-/jobs/798546354
> >  
> > > Aleksandr Lyapunov (1):
> > >   memtx: make tuple compare hints optional
> > > 
> > > Ilya Kosarev (1):
> > >   memtx: move memtx_tree.c to memtx_tree.cc
> > > 
> > >  src/box/CMakeLists.txt              |    2 +-
> > >  src/box/index_def.c                 |    2 +
> > >  src/box/index_def.h                 |    6 +
> > >  src/box/lua/schema.lua              |   53 ++
> > >  src/box/lua/space.cc                |    7 +
> > >  src/box/memtx_engine.c              |    2 +
> > >  src/box/memtx_tree.c                | 1523 -------------------------------
> > >  src/box/memtx_tree.cc               | 1723 +++++++++++++++++++++++++++++++++++
> > >  src/lib/salad/bps_tree.h            |   19 +
> > >  test/box/alter.result               |  103 ++-
> > >  test/box/alter.test.lua             |   34 +
> > >  test/box/errinj.result              |    3 +-
> > >  test/box/tree_pk.result             |  314 +++++++
> > >  test/box/tree_pk.test.lua           |  115 +++
> > >  test/box/tree_pk_multipart.result   |  153 ++++
> > >  test/box/tree_pk_multipart.test.lua |   64 ++
> > >  16 files changed, 2595 insertions(+), 1528 deletions(-)
> > >  delete mode 100644 src/box/memtx_tree.c
> > >  create mode 100644 src/box/memtx_tree.cc
> > > 
> > > -- 
> > > 2.7.4
> > >