Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Make tree hint optional
Date: Wed, 21 Oct 2020 20:02:59 +0300	[thread overview]
Message-ID: <20201021170259.GA364452@hpalx> (raw)
In-Reply-To: <20201020010157.GA22095@tarantool.org>

Hi Aleksandr, thanks for the patch. As I see in results it doesn't have
any new degradations[1]. Patchset LGTM.

https://gitlab.com/tarantool/tarantool/-/pipelines/205874308

On Tue, Oct 20, 2020 at 01:01:57AM +0000, Nikita Pettik wrote:
> On 19 Oct 12:51, Aleksandr Lyapunov wrote:
> > https://github.com/tarantool/tarantool/issues/4927
> > https://github.com/tarantool/tarantool/tree/alyapunov/gh-4927-optional-hints
> 
> Release fails to build:
> https://gitlab.com/tarantool/tarantool/-/jobs/798546360
> https://gitlab.com/tarantool/tarantool/-/jobs/798546354
>  
> > Aleksandr Lyapunov (1):
> >   memtx: make tuple compare hints optional
> > 
> > Ilya Kosarev (1):
> >   memtx: move memtx_tree.c to memtx_tree.cc
> > 
> >  src/box/CMakeLists.txt              |    2 +-
> >  src/box/index_def.c                 |    2 +
> >  src/box/index_def.h                 |    6 +
> >  src/box/lua/schema.lua              |   53 ++
> >  src/box/lua/space.cc                |    7 +
> >  src/box/memtx_engine.c              |    2 +
> >  src/box/memtx_tree.c                | 1523 -------------------------------
> >  src/box/memtx_tree.cc               | 1723 +++++++++++++++++++++++++++++++++++
> >  src/lib/salad/bps_tree.h            |   19 +
> >  test/box/alter.result               |  103 ++-
> >  test/box/alter.test.lua             |   34 +
> >  test/box/errinj.result              |    3 +-
> >  test/box/tree_pk.result             |  314 +++++++
> >  test/box/tree_pk.test.lua           |  115 +++
> >  test/box/tree_pk_multipart.result   |  153 ++++
> >  test/box/tree_pk_multipart.test.lua |   64 ++
> >  16 files changed, 2595 insertions(+), 1528 deletions(-)
> >  delete mode 100644 src/box/memtx_tree.c
> >  create mode 100644 src/box/memtx_tree.cc
> > 
> > -- 
> > 2.7.4
> > 

  reply	other threads:[~2020-10-21 17:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19  9:51 Aleksandr Lyapunov
2020-10-19  9:51 ` [Tarantool-patches] [PATCH 1/2] memtx: move memtx_tree.c to memtx_tree.cc Aleksandr Lyapunov
2020-10-19  9:51 ` [Tarantool-patches] [PATCH 2/2] memtx: make tuple compare hints optional Aleksandr Lyapunov
2020-10-20 12:34   ` Ilya Kosarev
2020-10-20 12:37     ` Nikita Pettik
2020-10-20 12:57       ` Ilya Kosarev
2020-10-21  9:54         ` Aleksandr Lyapunov
2020-10-20  1:01 ` [Tarantool-patches] [PATCH 0/2] Make tree hint optional Nikita Pettik
2020-10-21 17:02   ` Alexander V. Tikhonov [this message]
2020-10-21 17:06     ` Nikita Pettik
  -- strict thread matches above, loose matches on Subject: below --
2020-10-19  9:26 Aleksandr Lyapunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201021170259.GA364452@hpalx \
    --to=avtikhon@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] Make tree hint optional' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox