From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8A30B469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 21 Oct 2020 19:07:54 +0300 (MSK)
Date: Wed, 21 Oct 2020 19:08:17 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201021160817.o7z3pqrc7jyle4ct@tkn_work_nb>
References: <cover.1602931403.git.skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1602931403.git.skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] Minor fixes for new LuaJIT
	extention library
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

LGTM from my side.

I don't see any problems in the patchset.

External Gentoo ebuild, Arch PKGBUILD, FreeBSD port do not list headers
to install explicitly (just like in-repo Debian rules).

https://github.com/tarantool/gentoo-overlay/blob/master/dev-db/tarantool/tarantool-9999.ebuild
https://github.com/archlinux/svntogit-community/blob/master/tarantool/trunk/PKGBUILD
https://svnweb.freebsd.org/ports/head/databases/tarantool/Makefile?view=markup

WBR, Alexander Turenko.

On Sat, Oct 17, 2020 at 02:13:29PM +0300, Sergey Kaplun wrote:
> This patchset consists from 2 parts:
> 1) Provide corresponding new LuaJIT header within tarantool at install.
> 2) Add missing public C API symbols from the new lib into exports.h
> 
> Branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5187-luajit-include-headers
> 
> CI is red, but fails related to replication tests or at osx_* jobs
> (see also https://github.com/tarantool/tarantool/issues/5423).
> CI: https://gitlab.com/tarantool/tarantool/-/pipelines/203892776
> 
> Sergey Kaplun (2):
>   build: provide missing LuaJIT lmisclib.h header
>   lua: add missing LuaJIT export symbols
> 
>  FreeBSD/databases/tarantool/pkg-plist | 1 +
>  cmake/luajit.cmake                    | 2 +-
>  rpm/tarantool.spec                    | 1 +
>  src/exports.h                         | 2 ++
>  4 files changed, 5 insertions(+), 1 deletion(-)
> 
> -- 
> 2.28.0
>