From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8923B469719 for ; Tue, 20 Oct 2020 19:31:19 +0300 (MSK) Date: Tue, 20 Oct 2020 16:31:18 +0000 From: Nikita Pettik Message-ID: <20201020163117.GB24591@tarantool.org> References: <20201020115454.GA1609601@hpalx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201020115454.GA1609601@hpalx> Subject: Re: [Tarantool-patches] [PATCH 0/2] Upsert upgrade test follow-up List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org On 20 Oct 14:54, Alexander V. Tikhonov wrote: > Hi Nikita, I've checked your patchset and test results in gitlab > https://gitlab.com/tarantool/tarantool/-/pipelines/204910880 > All results are good. All failed testing I've checked and see that > they are known by the other issues and no new degradation found. > Patchset LGTM. Pushed to master, branch is dropped. > On Thu, Oct 15, 2020 at 05:33:08PM +0300, Nikita Pettik wrote: > > As Vlad noticed (after patch was pushed) it is better to follow > > more extendible folder structure for upgrade tests (to ease its > > maintenance). This patch clean-ups current vinyl/upgrade tests and > > make it look the same as xlog/upgrade folder. > > > > Branch: > > https://github.com/tarantool/tarantool/tree/np/gh-5107-upsert-upgrade-followup > > > > Nikita Pettik (2): > > vinyl: remove vinyl/upgrade.test.lua > > vinyl: reorganize vinyl/upsert_upgrade.test.lua > > > > test/vinyl/suite.cfg | 3 - > > test/vinyl/suite.ini | 2 +- > > test/vinyl/upgrade.lua | 7 - > > test/vinyl/upgrade.test.lua | 20 --- > > .../00000000000000000000.vylog | Bin > > .../00000000000000000004.vylog | Bin > > .../00000000000000000004.xlog | Bin > > .../00000000000000000010.vylog | Bin > > .../00000000000000000010.xlog | 0 > > .../512/0/00000000000000000002.index | Bin > > .../512/0/00000000000000000002.run | Bin > > .../512/0/00000000000000000004.index | Bin > > .../512/0/00000000000000000004.run | Bin > > .../512/0/00000000000000000006.index | Bin > > .../512/0/00000000000000000006.run | Bin > > .../2.5.1/gh-5107-upsert-upgrade/fill.lua | 15 ++ > > test/vinyl/upgrade/fill.lua | 136 ------------------ > > .../upgrade/upsert/00000000000000000004.snap | Bin 6187 -> 0 bytes > > .../upgrade/upsert/00000000000000000010.snap | Bin 6188 -> 0 bytes > > test/vinyl/upsert_upgrade.result | 59 -------- > > test/vinyl/upsert_upgrade.test.lua | 32 ----- > > 21 files changed, 16 insertions(+), 258 deletions(-) > > delete mode 100644 test/vinyl/upgrade.lua > > delete mode 100644 test/vinyl/upgrade.test.lua > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/00000000000000000000.vylog (100%) > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/00000000000000000004.vylog (100%) > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/00000000000000000004.xlog (100%) > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/00000000000000000010.vylog (100%) > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/00000000000000000010.xlog (100%) > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/512/0/00000000000000000002.index (100%) > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/512/0/00000000000000000002.run (100%) > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/512/0/00000000000000000004.index (100%) > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/512/0/00000000000000000004.run (100%) > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/512/0/00000000000000000006.index (100%) > > rename test/vinyl/upgrade/{upsert => 2.5.1/gh-5107-upsert-upgrade}/512/0/00000000000000000006.run (100%) > > create mode 100644 test/vinyl/upgrade/2.5.1/gh-5107-upsert-upgrade/fill.lua > > delete mode 100644 test/vinyl/upgrade/fill.lua > > delete mode 100644 test/vinyl/upgrade/upsert/00000000000000000004.snap > > delete mode 100644 test/vinyl/upgrade/upsert/00000000000000000010.snap > > delete mode 100644 test/vinyl/upsert_upgrade.result > > delete mode 100644 test/vinyl/upsert_upgrade.test.lua > > > > -- > > 2.17.1 > >