From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 92D9E469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 20 Oct 2020 15:44:37 +0300 (MSK)
Date: Tue, 20 Oct 2020 15:44:36 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20201020124436.GE10320@tarantool.org>
References: <20201017114459.18598-1-skaplun@tarantool.org>
 <20201020110600.GF5396@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201020110600.GF5396@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] test: fix warning for old gcc at
	testgetmetrics.c
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

The patch is LGTM, wording in the commit message still needs updates
(the latest branch log below).

Sergos

> commit 7a4c686e61bb70defe56e4e823ae09ce98c8dc04 (HEAD -> skaplun/gh-5187-old-gcc-warning, origin/skaplun/gh-5187-old-gcc-warning)
> Author: Sergey Kaplun <skaplun@tarantool.org>
> Date:   Sat Oct 17 09:13:07 2020 +0300
> 
>     test: fix warning for old gcc at testgetmetrics.c
> 
>     This patch fixes the regression introduced in scope of
>     5a61e1ab54b5c66bfebd836db1ac47996611e065 ('misc: add C and Lua
>     API for platform metrics').
> 
>     Old gcc compiler (gcc-4.8.5-39) throws warnings like:
>     "error: comparison is always true due to limited range of data type
>     [-Werror=type-limits]", when you cast syze_t value to ssyze_t type and

size instead of syze

>     compare its to >= 0. This leads to failing compilation with -Werror

compare it, not its

>     flag.
> 
>     Taking into account that this base test check only API format, not
>     values by themself, it will be enough to use (void) construction here.

by themself -> themselves

> 
>     Follows up tarantool/tarantool#5187
>