From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 17DCD469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 20 Oct 2020 15:29:23 +0300 (MSK)
Date: Tue, 20 Oct 2020 15:29:22 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20201020122922.GD10320@tarantool.org>
References: <cover.1602859961.git.skaplun@tarantool.org>
 <fa8e77389df6e3dace602e3722e583ec0b3baf34.1602859961.git.skaplun@tarantool.org>
 <20201016194939.GA17612@root> <20201018181926.GB5396@tarantool.org>
 <20201019043545.GB1834@root>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201019043545.GB1834@root>
Subject: Re: [Tarantool-patches] [PATCH 2/3] misc: add lib_misc.c to all
	.bat files
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

Thanks for the patch and review! 

LGTM.

Sergos

On 19 окт 07:35, Sergey Kaplun wrote:
> Igor,
> 
> Thanks for the review! I've updated commit message considering your
> comments. Branch is force pushed.
> 
> On 18.10.20, Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the patch! The fix looks quite clear, but I have no way to
> > check it by myself. This breaks nothing, so LGTM, but please consider my
> > nits below.
> > 
> > On 16.10.20, Sergey Kaplun wrote:
> 
> <snipped>
> 
> > 
> > Minor: I believe <build> is much better here instead of <misc>.
> 
> Yes, updated.
> 
> > 
> > >     
> > >     For become symbols exportable at several building systems
> > 
> > Typo: s/For become/To make/.
> 
> Yep, thanks!
> 
> > 
> > >     (namely mvsc, xedk, xb1) LuaJIT defines LUA_BUILD_AS_DLL at
> > >     corresponding bat files.  When this macro is defined, the definition of
> > 
> > Typo: Doubled whitespace above.
> 
> Thanks again!
> 
> > 
> > >     LUA_API macro depends on LUA_CORE and LUA_LIB macros (see luaconf.h). If
> > >     defined(LUA_CORE) or defined(LUA_LIB) then LUA_API macro is defined as
> > >     __declspec(dllexport). Otherwise, it defined as __declspec(dllimport).
> > 
> > Typo: s/it defined/it is defined/.
> 
> Fixed.
> 
> > 
> > >     
> > >     This patch consists from two parts.
> > >     
> > >     First of all it adds lib_misc.c to ALL_LIB in .bat files
> > >     for specific building systems.
> > >     
> > >     Secondly, this patch also adds definition of LUA_CORE macro at the top
> > >     of lj_mapi.c file to make corresponding symbols exportable for systems
> > >     described above.
> > >     
> > >     Follows up tarantool/tarantool#5187
> > > 
> > 
> > <snipped>
> > 
> > > ===================================================================
> > > 
> > > -- 
> > > Best regards,
> > > Sergey Kaplun
> > 
> > -- 
> > Best regards,
> > IM
> 
> -- 
> Best regards,
> Sergey Kaplun