From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BEB39469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 20 Oct 2020 15:09:13 +0300 (MSK)
Date: Tue, 20 Oct 2020 15:09:12 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20201020120912.GB10320@tarantool.org>
References: <cover.1602931403.git.skaplun@tarantool.org>
 <c878e5cbee2c1259773887fa1a46046676cf40e5.1602931403.git.skaplun@tarantool.org>
 <20201018184316.GD5396@tarantool.org> <20201019045715.GD1834@root>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201019045715.GD1834@root>
Subject: Re: [Tarantool-patches] [PATCH 2/2] lua: add missing LuaJIT export
 symbols
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi!

I reviewed the latest branch, LGTM with some updates in message below.

On 19 окт 07:57, Sergey Kaplun wrote:
> Igor,
> 
> Thanks for the review! I've updated commit message considering your
> comment here. Branch is force pushed.
> 
> On 18.10.20, Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the patch! LGTM, except a single nit.
> > 
> > On 17.10.20, Sergey Kaplun wrote:
> > > Since LuaJIT provides public C API symbols that are used in the final
> > > executable, the linker may not just throw it away.
> > > Nevertheless for future compatibility all symbols from LuaJIT public API
> > > should be additionaly added at exports.h file.
                ^^^^^^^^^^^^^^^^^^^^
Perhaps simply
                added to

> > > 
> > > Follows up tarantool/tarantool#5187
> > 
> > Minor: You don't need to use full repo reference here.
> > 
> > > ---
> > >  src/exports.h | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > 
> > <snipped>
> > 
> > > -- 
> > > 2.28.0
> > > 
> > 
> > -- 
> > Best regards,
> > IM
> 
> -- 
> Best regards,
> Sergey Kaplun