From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1E47E469719
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 18 Oct 2020 21:57:36 +0300 (MSK)
Date: Sun, 18 Oct 2020 21:43:17 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201018184316.GD5396@tarantool.org>
References: <cover.1602931403.git.skaplun@tarantool.org>
 <c878e5cbee2c1259773887fa1a46046676cf40e5.1602931403.git.skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c878e5cbee2c1259773887fa1a46046676cf40e5.1602931403.git.skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/2] lua: add missing LuaJIT export
	symbols
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Sergey,

Thanks for the patch! LGTM, except a single nit.

On 17.10.20, Sergey Kaplun wrote:
> Since LuaJIT provides public C API symbols that are used in the final
> executable, the linker may not just throw it away.
> Nevertheless for future compatibility all symbols from LuaJIT public API
> should be additionaly added at exports.h file.
> 
> Follows up tarantool/tarantool#5187

Minor: You don't need to use full repo reference here.

> ---
>  src/exports.h | 2 ++
>  1 file changed, 2 insertions(+)
> 

<snipped>

> -- 
> 2.28.0
> 

-- 
Best regards,
IM