From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8DEB6469719
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 18 Oct 2020 21:33:45 +0300 (MSK)
Date: Sun, 18 Oct 2020 21:19:26 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201018181926.GB5396@tarantool.org>
References: <cover.1602859961.git.skaplun@tarantool.org>
 <fa8e77389df6e3dace602e3722e583ec0b3baf34.1602859961.git.skaplun@tarantool.org>
 <20201016194939.GA17612@root>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201016194939.GA17612@root>
Subject: Re: [Tarantool-patches] [PATCH 2/3] misc: add lib_misc.c to all
	.bat files
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sergey,

Thanks for the patch! The fix looks quite clear, but I have no way to
check it by myself. This breaks nothing, so LGTM, but please consider my
nits below.

On 16.10.20, Sergey Kaplun wrote:
> 
> Since neither this patch compiles without the following, nor vice versa,
> I have merged these two commits into one.
> 
> Side note 1: Forgot to say in previous letter: `#define lj_mapi_c` added
> for consistency with other LUA_CORE files. AFAIK it is not used
> anywhere.

I also failed to find any usage for it. I found <luajit_c> usage in
luaconf.h. Also, there is <ljamalg_c> usage in lj_def.h. Anyway, I'm for
leaving this line for the sources consistency.

> 
> Side note 2: ^M symbols that you may see in your favorite editor is 0xD
> character - the carriage return character. Unix uses 0xA for a newline
> character. Windows uses a combination of two characters: 0xD and 0xA.
> 
> See new full patch below. Branch is force pushed.
> 
> ===================================================================
> commit d3952c3553d78725a565ee535e28e675036cf7d3
> Author: Sergey Kaplun <skaplun@tarantool.org>
> Date:   Fri Oct 16 15:48:08 2020 +0300
> 
>     misc: fix build for Windows-like systems

Minor: I believe <build> is much better here instead of <misc>.

>     
>     For become symbols exportable at several building systems

Typo: s/For become/To make/.

>     (namely mvsc, xedk, xb1) LuaJIT defines LUA_BUILD_AS_DLL at
>     corresponding bat files.  When this macro is defined, the definition of

Typo: Doubled whitespace above.

>     LUA_API macro depends on LUA_CORE and LUA_LIB macros (see luaconf.h). If
>     defined(LUA_CORE) or defined(LUA_LIB) then LUA_API macro is defined as
>     __declspec(dllexport). Otherwise, it defined as __declspec(dllimport).

Typo: s/it defined/it is defined/.

>     
>     This patch consists from two parts.
>     
>     First of all it adds lib_misc.c to ALL_LIB in .bat files
>     for specific building systems.
>     
>     Secondly, this patch also adds definition of LUA_CORE macro at the top
>     of lj_mapi.c file to make corresponding symbols exportable for systems
>     described above.
>     
>     Follows up tarantool/tarantool#5187
> 

<snipped>

> ===================================================================
> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM