From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 992DD469719
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 18 Oct 2020 19:53:26 +0300 (MSK)
Date: Sun, 18 Oct 2020 19:39:06 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201018163906.GA5396@tarantool.org>
References: <cover.1602859961.git.skaplun@tarantool.org>
 <dcd8483d540f1d66ffc5a95dd7d0f624190bde26.1602859961.git.skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <dcd8483d540f1d66ffc5a95dd7d0f624190bde26.1602859961.git.skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/3] misc: add lmisclib.h to lua.hpp
	header
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sergey,

Thanks for the patch! LGTM, no questions.

On 16.10.20, Sergey Kaplun wrote:
> This patch adds missing lmisclib.h header to C++ wrapper
> for LuaJIT header files as part of extended public API.
> 
> Follows up tarantool/tarantool#5187
> ---
>  src/lua.hpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/lua.hpp b/src/lua.hpp
> index 07e9002..56ae165 100644
> --- a/src/lua.hpp
> +++ b/src/lua.hpp
> @@ -5,5 +5,6 @@ extern "C" {
>  #include "lauxlib.h"
>  #include "lualib.h"
>  #include "luajit.h"
> +#include "lmisclib.h"
>  }
>  
> -- 
> 2.28.0
> 

-- 
Best regards,
IM