From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6100F469719 for ; Fri, 16 Oct 2020 20:17:31 +0300 (MSK) Date: Fri, 16 Oct 2020 20:17:29 +0300 From: "Alexander V. Tikhonov" Message-ID: <20201016171729.GA501145@hpalx> References: <158f8ce7d18ca54cc2ed343ecd3d19d686220f1d.1602867171.git.tsafin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158f8ce7d18ca54cc2ed343ecd3d19d686220f1d.1602867171.git.tsafin@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] module api: fix asan failures in test List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Timur Safin Cc: tarantool-patches@dev.tarantool.org Hi Timur, thanks for the patch. As I see in results [1] it really fixed the issue. Patch LGTM. [1] - https://gitlab.com/tarantool/tarantool/-/jobs/795704534#L4636 On Fri, Oct 16, 2020 at 07:57:28PM +0300, Timur Safin wrote: > Adding forgotten resource cleanup to the > `test_tuple_validate_formatted` test, to make ASAN > happy again. > > Closes #5432 > Relates to #5384 > --- > > Branch is tsafin/gh-5432-module-api-asan-fix > > test/app-tap/module_api.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/test/app-tap/module_api.c b/test/app-tap/module_api.c > index 7ca0c9a15..ce7fa2353 100644 > --- a/test/app-tap/module_api.c > +++ b/test/app-tap/module_api.c > @@ -2327,6 +2327,8 @@ test_tuple_validate_formatted(lua_State *L) > assert(format); > > valid = box_tuple_validate(tuple, format) == 0; > + box_tuple_format_unref(format); > + box_key_def_delete(key_defs[0]); > } > lua_pushboolean(L, valid); > > -- > 2.20.1 >