From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1A5EB469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 16 Oct 2020 16:05:25 +0300 (MSK)
Date: Fri, 16 Oct 2020 15:54:47 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201016125447.GL32659@tarantool.org>
References: <cover.1602846789.git.imun@tarantool.org>
 <20201016125924.GA450900@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201016125924.GA450900@hpalx>
Subject: Re: [Tarantool-patches] [PATCH] Remove hardcoded paths to LuaJIT
	tests
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

Thanks for your review!

On 16.10.20, Alexander V. Tikhonov wrote:
> Hi Igor, thanks for the patchset. As I see now issues appeared on it and
> it really fixed testing. Patchset LGTM.

Added your tag:
| Reviewed-by: Alexander V. Tikhonov <avtikhon@tarantool.org>

> 
> On Fri, Oct 16, 2020 at 03:11:32PM +0300, Igor Munkin wrote:
> > As a result of the review[1] for Timur patch, I've finally got the idea
> > how to reduce the struggling Kirill faces every time there is a new test
> > created within LuaJIT third party repo. The series contains of two
> > patches in both repos:
> > * the root CMakeLists.txt for test directory is introduced to LuaJIT
> >   repo in scope of the first patch
> > * the paths in test/CMakeLists.txt are accordingly adjusted
> > 
> > Issue: https://github.com/tarantool/tarantool/issues/5425
> > LuaJIT repo branches:
> > * https://github.com/tarantool/luajit/tree/imun/gh-5425-luajit-tests-cmake
> > * https://github.com/tarantool/luajit/tree/imun/gh-5425-luajit-tests-cmake-2.5
> > Tarantool repo branch (need to be cherry-picked to all stable branches):
> > * https://github.com/tarantool/tarantool/tree/imun/gh-5425-luajit-tests-cmake
> > 
> > CI is not green, but I've done my best. I see neither build fails nor
> > failures related to the luajit-tap tests here:
> > * https://gitlab.com/tarantool/tarantool/-/pipelines/203537445
> > 
> > [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-October/020266.html
> > 
> > -- 
> > 2.25.0
> > 

-- 
Best regards,
IM