From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 733F1469719 for ; Fri, 16 Oct 2020 10:16:18 +0300 (MSK) Date: Fri, 16 Oct 2020 10:16:13 +0300 From: Kirill Yukhin Message-ID: <20201016071613.hxlt4f5j4k7uuywd@tarantool.org> References: <470cb12f9bcce14409c28de104e4e442fc9d37d2.1602801983.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <470cb12f9bcce14409c28de104e4e442fc9d37d2.1602801983.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/1] raft: fix crash when leader resigned from its role List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Hello, On 16 окт 00:47, Vladislav Shpilevoy wrote: > Nodes with disabled Raft keep listening for Raft events and > persist them. To be able to quickly enroll into the process if > they are configured to be candidates. > > The same for the voter nodes - they can't be a leader, but watch > and persist all what is happening. > > However when a leader resigned from its role, the voter and > disabled nodes tried to start a new election round, even though > they were not supposed to. That led to a crash, and is fixed in > this patch. > > Closes #5426 > --- > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5426-raft-crash-on-election-toogle > Issue: https://github.com/tarantool/tarantool/issues/5426 LGTM. I've checked your patch into master. -- Regards, Kirill Yukhin