From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8BCBC469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 16 Oct 2020 09:10:27 +0300 (MSK)
Date: Fri, 16 Oct 2020 09:10:47 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201016061047.eduhu4ul7fkkabm4@tkn_work_nb>
References: <cover.1602629628.git.tsafin@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1602629628.git.tsafin@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2.X v4 0/4] module api: extend for
 external merger Lua module
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Timur Safin <tsafin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

The patchset looks good to me in general, however I agree with Vlad that
it would be good to polish it if we would not have so tight timeline.

I made several changes before pushing:

- 'module api: box_ibuf_* wrappers' is applied first (we need it to use
  <box_ibuf_t> for luaT_toibuf() later).
- Use <box_ibuf_t> in luaT_toibuf(). And so moved the box/ibuf.h header
  before lua/utils.h in the list of the API headers.
- Marked the last commit as 'Closes #5384' instead of 'Part of #5384'.
- Moved the luaL_iscallable 1.10 backport as first to form the proper
  chain of 'part of', 'part of', ... 'closes'.
- Found and fixed 'unused variable' warnings on module_api.c on
  RelWithDebInfo build.

Pushed to master, 2.5, 2.4 and 1.10.

WBR, Alexander Turenko.