From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 99B32469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 16 Oct 2020 09:05:32 +0300 (MSK)
Date: Fri, 16 Oct 2020 09:05:52 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201016060552.yfk64ogajv3m3ql6@tkn_work_nb>
References: <cover.1602541394.git.alexander.turenko@tarantool.org>
 <20201015131957.sabrixdqbkksuzwg@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201015131957.sabrixdqbkksuzwg@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH v3 00/16] module api: extend for
 external key_def Lua module
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Thu, Oct 15, 2020 at 04:19:58PM +0300, Alexander Turenko wrote:
> Updated.
> 
> Changes from v3 to the final version (I hope it is final):
> 
> - Fixed sorting of the box region functions in src/exports.h.
> - Added forgotten API_EXPORT for box_region_truncate().
> - Added a comment for luaT_tuple_encode_table() reference in the Lua registry.
> - Added the <size_t *key_size_ptr> parameter to box_key_def_validate_key() and
>   box_key_def_validate_full_key().
> - Fixed API comments for key_def functions with mention of the diagnostics
>   area.
> - Set a memory error to the diagnostics area for box_region_*alloc() functions.

List of changes that I made before pushing:

- test_iscdata(): fixed negative index testing:
  | - lua_pushboolean(L, res == exp);
  | + lua_pushboolean(L, ok);
- Found and fixed 'unused variable' warnings on module_api.c on
  RelWithDebInfo build.

Pushed to master, 2.5, 2.4 and 1.10.

Many thanks to Vlad for help with designing, eagle eyes and fast
responses.

WBR, Alexander Turenko.